Fix incorrect face usage and undeclared list elements type#1872
Merged
purcell merged 2 commits intohaskell:masterfrom Mar 5, 2025
Merged
Fix incorrect face usage and undeclared list elements type#1872purcell merged 2 commits intohaskell:masterfrom
purcell merged 2 commits intohaskell:masterfrom
Conversation
A face is represented by a symbol, however representing a symbol
inside lists requires no quoting. So remove the quote.
Fixes warning:
haskell-c2hs.el:37:19: Error: in defface for ‘haskell-c2hs-hook-pair-face’: Value for face attribute ‘:inherit’ should not be quoted
Fixes:
haskell-commands.el:49:10: Error: in defcustom for ‘haskell-mode-stylish-haskell-args’: ‘list’ without arguments
Member
|
Yes, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a few warnings. Couldn't fix more because it complains
if-letbeing an obsolete macro and thatif-let*should be preferred, but I'm not sure what's the best course of action here.if-let*appeared since 26.1, so it's either upping the minimal version 26.1 or adding a wrapper for older Emacses. Emacs 26.1 was released in 2018.